🍒 [windows][lldb] implement system logging on Windows (#150213) #11096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charles-zablit
commented
Jul 31, 2025
charles-zablit
commented
- [windows][lldb] implement system logging on Windows llvm/llvm-project#150213
This patch makes LLDB use the Event Viewer on Windows (equivalent of system logging on Darwin) rather than piping to the standard output (which was deactivated in ca0a524.
|
@swift-ci please test |
adrian-prantl
approved these changes
Aug 4, 2025
|
@swift-ci please test windows |
|
@swift-ci please test |
|
@swift-ci please test Windows |
|
@swift-ci please test windows |
|
@swift-ci please test Windows |
compnerd
reviewed
Aug 7, 2025
| event_type = EVENTLOG_INFORMATION_TYPE; | ||
| } | ||
|
|
||
| ReportEventW(h, event_type, 0, 0, nullptr, 1, 0, &msg_ptr, nullptr); |
There was a problem hiding this comment.
Is this really the best place to put the messages? The Event Log is for system events, this feels more developer oriented and feels like the kernel debug buffer might be better (OutputDebugStringA).
| std::wstring unicode(unicode_length, L'\0'); | ||
| MultiByteToWideChar(CP_ACP, 0, ansi.c_str(), -1, &unicode[0], unicode_length); | ||
| return unicode; | ||
| } |
There was a problem hiding this comment.
Why re-implement UTF8ToUTF16 and UTF16ToUTF8 from LLVM?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.